Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ffmpeg error with bin_data streams #15846

Closed
wants to merge 2 commits into from
+3 −0
Closed

Fix ffmpeg error with bin_data streams #15846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d90b76
Fix ffmpeg error with bin_data streams
Tatsh Mar 13, 2018
a13211f
Merge remote-tracking branch 'upstream/master' into fix-bin_data-error
Tatsh May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions youtube_dl/postprocessor/ffmpeg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ def run_ffmpeg_multiple_files(self, input_paths, out_path, opts):
encodeFilename(self._ffmpeg_filename_argument(path), True)
])
cmd = ([encodeFilename(self.executable, True), encodeArgument('-y')] +
['-loglevel', 'repeat+info'] +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mix unrelated changes in single PR.

files_cmd +
[encodeArgument(o) for o in opts] +
[encodeFilename(self._ffmpeg_filename_argument(out_path), True)])
Expand Down Expand Up @@ -379,6 +380,8 @@ def run(self, information):
# Don't copy the existing subtitles, we may be running the
# postprocessor a second time
'-map', '-0:s',
# Don't copy Apple TV subtitles format, bin_data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a chapters track as explained in the ffmpeg issue you linked that appears after chapters metadata is embedded by --add-metadata.

'-map', '-0:d',
]
if information['ext'] == 'mp4':
opts += ['-c:s', 'mov_text']
Expand Down