Fix ffmpeg error with bin_data streams #15846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example YouTube ID: KaAdS8Oso9U Also disable "Last message repeated" messages which cause non-zero exit status
|
Provide complete verbose log demonstrating the issue this PR is supposed to fix. |
The above Last message repeated 1 times is the wrong message to report, and it is not important for users most of the time. So I have filtered it out with The real error is To fix the command, add |
|
@dstftw what are the fixes you are looking for? |
dstftw
requested changes
Jan 26, 2019
| @@ -379,6 +380,8 @@ def run(self, information): | |||
| # Don't copy the existing subtitles, we may be running the | |||
| # postprocessor a second time | |||
| '-map', '-0:s', | |||
| # Don't copy Apple TV subtitles format, bin_data | |||
There was a problem hiding this comment.
It's a chapters track as explained in the ffmpeg issue you linked that appears after chapters metadata is embedded by --add-metadata.
| @@ -190,6 +190,7 @@ def run_ffmpeg_multiple_files(self, input_paths, out_path, opts): | |||
| encodeFilename(self._ffmpeg_filename_argument(path), True) | |||
| ]) | |||
| cmd = ([encodeFilename(self.executable, True), encodeArgument('-y')] + | |||
| ['-loglevel', 'repeat+info'] + | |||
There was a problem hiding this comment.
Don't mix unrelated changes in single PR.
|
I cannot push to this branch anymore. I will open a new PR. |
This was referenced Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Some files coming from YouTube and probably others come with chapter data (or subtitle?) in a stream seen by ffmpeg as the
bin_datacodec, usually at0:2. Without some help, ffmpeg will simply refuse to make an mp4 file containing this. This causes the subtitle post-processor to fail, which also stops any further processing (embed thumbnail, etc).This PR adjusts the subtitle post-processor to 'disable' (but not really) all data streams in the ffmpeg command. The resulting files still end up having the bin_data stream, but the SRT subtitle is now properly embedded before it:
Example YouTube ID: KaAdS8Oso9U
Related ffmpeg issue
This also disables "Last message repeated" messages which cause non-zero exit status. Most of the time these messages are programmer issues for the ffmpeg team and do not apply to users.