Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adobepass] add verizon_hba mso and verizon saml improvements #14363

Closed
wants to merge 2 commits into from

Conversation

SkiTheSlicer
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Turner extractors (AdultSwim, TNT, TBS, etc) use "Verizon_HBA" instead of "Verizon" as the MSO name, though the credentials are the same.

Also, I've encountered some additional login pipelines that are used by providers such as USA that have given me problems. This appears to also be flagged as issue #13848.

@SkiTheSlicer SkiTheSlicer changed the title add verizon_hba mso and verizon saml improvements [adobepass] add verizon_hba mso and verizon saml improvements Sep 29, 2017
@beren12
Copy link

beren12 commented Nov 1, 2017

this is needed for disney jr now as well

@ghost
Copy link

ghost commented Jan 26, 2018

Any reason this isn't merged yet? It fixes Verizon login for me.

@Zenexer
Copy link

Zenexer commented Apr 24, 2018

@rg3 Could you consider merging this? It's a very simple addition that fixes several popular sites for Verizon users.

@rg3
Copy link
Collaborator

rg3 commented Apr 25, 2018

Pinging the current maintainers: @dstftw

@Zenexer
Copy link

Zenexer commented Apr 26, 2018

I merged this PR into master locally and confirmed that it does work for Turner services (e.g., TBS, Adult Swim). Haven't tested other streaming services yet.

@beren12
Copy link

beren12 commented Apr 26, 2018 via email

@ParadoxGBB
Copy link

I'm a big fan of YouTube-dl and hit this as well --- I applied this PR a while back and it started failing again about 8/25.

I'm not very familiar with Python, but I took the liberty of investigating and fixing the recent problems I observed while trying to extract TBS and A&E content with YouTube-DL via Verizon credentials. Many thanks to @SkiTheSlicer for the original work around this.

https://bitbucket.org/ParadoxGBB/youtube-dl/commits/64bddfe15c1458a1b3461875bf9afd0a17ebeea0

Basically:

  1. The SAML redirection URL javascript code shifted a bit (although I don't have a snapshot to see how this worked prior). I'm not really happy with the code here to reconstitute a valid URL and I've been unsuccessful in finding a library call to make this more elegant, so anyone here who is more familiar, I'd be much obliged. Also, since this time it appears that TBS no longer needs a MSO designation of VERIZON_HBA, so I removed that additional option.

  2. TBS / TNT extraction, while it works with the newer ngtv sources (Http Error 504 #17336), always grabs the first video in the source page's playlist with often does not match the source for the original page request. I added a little bit of logic to iterate and find the matching video identification that matches the specified original URL.

I'd love help in getting these changes merged back into the main branch if possible.

@SkiTheSlicer
Copy link
Author

I unfortunately don't have Verizon FiOS TV services anymore to test any changes. I wouldn't feel comfortable updating this PR without it. Hopefully someone else out there with credentials is able to work it out with you.

@beren12
Copy link

beren12 commented Jan 8, 2019

Could someone please help update this and get it into mainline? If needed I can provide a temp verizon login...

@beren12
Copy link

beren12 commented Jan 8, 2019

BTW The update from @ParadoxGBB is letting me download from https://disneynow.go.com with Verizon. I have not tried TBS.

keithah referenced this pull request in keithah/youtube-dl Feb 4, 2019
@dirkf dirkf closed this Aug 1, 2023
@dirkf dirkf added the defunct PR source branch is not accessible label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible tv-provider-account-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants