change --json to --output json
#128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These also found bugs in the output! D-:
There wasn't actually the major bug I thought I had in the output. I'd
written the markdown as:
two[1]
... which was just a plain `two`, plus a shorcut link `[1]`. That
shortcut link then got reformatted to a full link.
I'd meant to write the markdown as:
[two][1].
They were being rendered not as just a single inline, but as individual items, with a thematic break between each -- as if they were individually selected, and then output via `-o md`. The correct form ended up being simpler, too!
yshavit
commented
Jul 16, 2024
Comment on lines
-95
to
-98
| link_reference_placement: ReferencePlacement::Doc, // but we won't actually write them | ||
| footnote_reference_placement: ReferencePlacement::Doc, // ditto | ||
| inline_options: MdInlinesWriterOptions { | ||
| link_format: LinkTransform::Keep, // unused here, but removing it is more refactoring than it's worth |
There was a problem hiding this comment.
The fact that I had all these unused options should have keyed me into the fact that something weird was going on! The link_format one I had even noted as a TODO to clean up earlier, but I decided it wasn't worth it in 329d1e4. I guess now it's done right!
be more consistent with others I have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default is
--output markdown.This way is more flexible in the future, if I want more output formats for whatever reason.
Also fix an unrelated bug in the JSON output, which I found when I added an integ test for it.
Resolves a TODO, in service of #11.