review all TODOs #11
Comments
It's already gone, and has been for a while. |
Merged
yshavit
added a commit
that referenced
this issue
Jul 16, 2024
Default is `--output markdown`. This way is more flexible in the future, if I want more output formats for whatever reason. Also fix an unrelated bug in the JSON output, which I found when I added an integ test for it. Resolves a TODO, in service of #11.
Merged
yshavit
added a commit
that referenced
this issue
Jul 17, 2024
I have two spots in the code that I wasn't able to produce cases for. I
suspect these can't happen, but just in case, I'm going to put basically
an overridable panic of sorts. By default, hitting either of these cases
will result in an error; but if you provide the hidden
`--allow-unknown-markdown` flag, we'll just ignore them.
I can't test this (if I knew how to hit these branches, I wouldn't need
it!), but I manually added a `lookups.unknown_markdown("testing")?;` in
`MdElem::read` to verify that (a) it correctly errors out without the
flag, and (b) it correctly succeeds with the flag.
As part of this, I added better handling for the Err case of
`MdElem::read`.
Also, replace a TODO with a reference to #84.
This PR removes all the TODOs for #11. Once it gets merged, I'll check
the last checkbox on that ticket and manually close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#[allow(dead_code)]I shouldn't do this until I get a bit more stable, though.
The text was updated successfully, but these errors were encountered: