-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint rule updates #673
Eslint rule updates #673
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left comments on a few of the noteworthy things I ran into while making this update. @djahandarie feel free to read them and just close them, as I don't have actions for them aside from just noting them.
Beyond that, if we run into any future issues with these rules causing trouble, I'm not opposed to disabling the problematic ones.
The general process I have tried to follow for the recent eslint rule updates, including this one, is to try to enable everything, and then disable things which don't match the existing style for the most part.
Resolves #615.