You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That unicorn plugin seems to have a lot of other potentially useful lints too, would you like to take a look at it and see which ones you agree with? I'm mostly fine to go with your opinion on what lints we use, but if there's anything you're on the fence on feel free to raise it and I'll add my opinion.
The text was updated successfully, but these errors were encountered:
djahandarie
changed the title
Introduce more lints from eslint-plugin-unicorn?
Introduce more lints from eslint-plugin-unicorn and eslint-plugin-sonarjs?
Feb 3, 2024
I'll take a look at them. I've used the sonar one before, so I think there is some good stuff in there. In general, there's a few things I should do with our eslint file, since I recently figured out what one of the issues was related to fully typed typescript analysis. I'll look into these as well as part of that.
Regarding #584 (comment):
@toasted-nutbread I found this lint https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-spread.md which seems to capture your advice here.
That unicorn plugin seems to have a lot of other potentially useful lints too, would you like to take a look at it and see which ones you agree with? I'm mostly fine to go with your opinion on what lints we use, but if there's anything you're on the fence on feel free to raise it and I'll add my opinion.
Also regarding #600 (comment):
I found https://github.com/SonarSource/eslint-plugin-sonarjs/blob/master/docs/rules/prefer-immediate-return.md. Same story here that sonarjs seems to have lots of other potentially useful lints that might be worth adopting.
The text was updated successfully, but these errors were encountered: