-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow breaking on rb tags when layout aware scanning is enabled #1006
Conversation
Are there cases in which the rb content should not be ignored? |
This change does not make it ignore rb content. This makes it so it doesn't interpret rb tags as a line break and it instead keeps scanning further. Here is an example of an rb tag being used: <ruby><rb>美</rb><rt>お</rt><rb>味</rb><rt>い</rt></ruby>しい Yomitan on firefox with layout aware scanning will only allow scanning 美, 味, or しい. not 美味しい. This change allows it to instead scan 美味しい. For clarity, rb tags are deprecated and should not be used but they are still present in some cases. The correct way to represent the above word with furigana would be: <ruby>美<rt>お</rt>味<rt>い</rt></ruby>しい |
Dumb, unrelated question but how is yomitan avoiding scanning 美お味いしい? |
Not totally sure how it works but we have this which seems to be doing some sort of filtering: If you try to scan an rt tag Yomitan just wont let you. |
Apparently not marking the tag as enterable slightly breaks the {sentence} handlebar even though scanning works fine. Fixed that. This should be totally good to go now. |
rb tags should be ignored by layout aware scanning. This bug only appears on firefox presumably due to chromium not properly supporting rb tags.
Fixes #888