Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yomitan cuts off sentence when <rb> tags are present if Layout-aware scanning is enabled #888

Closed
Mansive opened this issue May 7, 2024 · 0 comments · Fixed by #1006
Closed
Labels
kind/bug The issue or PR is regarding a bug

Comments

@Mansive
Copy link

Mansive commented May 7, 2024

Description
If I mine "キュッと" from the sentence in the screenshot, the sentence handlebar will only output "そしてキュッと摑" for Anki instead of the full sentence. One method I've found for fixing this without removing furigana entirely is by removing <rb> HTML tags from the epub. This behavior has existed since the times before Yomichan was sunset.
image
The HTML for the sentence in question: そしてキュッと<ruby><rb>摑</rb><rt>つか</rt></ruby>まれる心に代わって、自らの<ruby><rb>肛</rb><rt>こう</rt><rb>門</rb><rt>もん</rt></ruby>をギュッと締め付ける。

I think this is unintended behavior because the settings page says Layout-aware scanning uses "webpage styling information to determine where line breaks are likely to be," and random furigana with <rb> tags are not line breaks.

Browser version
Firefox Developer Edition 126.0b9

Yomitan version
24.5.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant