Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Rendering Bug Fix and add backward compatibility for deprecated function in render creator #13

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Jul 5, 2024

Changelog Description

Resolve #11 where blackscreen is rendered.

  • Instead of using the level created along with the instance, the local render function would always use the persistent level for rendering if the level from the render instance is not persistent
  • This ticket adds the check on the selection for the instance data asset. If the users dont choose the instance data for rendering, it will show the popup menu.
  • This ticket also adds new function to find the current level in render creator while some backward compatibility implemented for the deprecated functions in or after UE 5.3

Additional Info

We should think if checking and raising the error for the current level not being persistent, instead of using the current level when the master level is not persistent.

  • Build Addon with this branch

Testing Notes

  1. Install Addon
  2. Launch Unreal
  3. Select your render instance data asset, and click Render... in AYON popup menu

image

  1. If you haven't selected your render instance data asset, it will raise error and show popup message.
  2. Once you selected your render instance data asset, and hit Render..., it should be rendering without blackscreen.

@moonyuet moonyuet requested review from antirotor and LiborBatek July 5, 2024 07:55
@moonyuet moonyuet marked this pull request as ready for review July 5, 2024 09:23
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did follow the testing steps and seems working fine...

When no Publish instance not selected warning pops up:

Screenshot 2024-07-05 123114

When selected I was able to render my image sequence...

moonyuet added 3 commits July 15, 2024 11:04
…ter level is not persistent level, and also make sure the create render has the update version of fucntion
@iLLiCiTiT iLLiCiTiT force-pushed the bugfix/Local-rendering-doesn't-work branch from 23ac670 to e887872 Compare July 15, 2024 09:19
@moonyuet moonyuet merged commit 6f8e4e7 into develop Jul 18, 2024
1 check passed
@moonyuet moonyuet deleted the bugfix/Local-rendering-doesn't-work branch July 18, 2024 07:35
@antirotor antirotor added the type: bug Something isn't working label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Local rendering doesn't work
3 participants