Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add staticMesh product type to loader plugin #10

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

antirotor
Copy link
Member

@antirotor antirotor commented Jul 2, 2024

Enhancement

Layout in Unreal supported just rig and model product types. This is adding also staticMesh and skeletonMesh.

Testing

  • Publish skeletalMesh and staticMesh products
  • Create Layout with them and publish it
  • Load it in Unreal

TODO:

  • add staticMesh
  • add skeletalMesh

@antirotor antirotor requested a review from LiborBatek July 2, 2024 15:04
@antirotor antirotor self-assigned this Jul 2, 2024
@iLLiCiTiT iLLiCiTiT force-pushed the enhancement/add-staticMesh-product-to-layout branch from 079e7b0 to 78341ff Compare July 15, 2024 09:18
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created Layout within maya consisting of skeletalMesh and staticMesh besides ordinary model assets and tried to load it into UE. Im getting this error msg


Error message: 'NoneType' object is not subscriptable

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_0.4.3\ayon_core\tools\loader\models\actions.py", line 740, in _load_representations_by_loader
    load_with_repre_context(
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_0.4.3\ayon_core\pipeline\load\utils.py", line 325, in load_with_repre_context
    return loader.load(repre_context, name, namespace, options)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Work\REPO\ayon-unreal\client\ayon_unreal\plugins\load\load_layout.py", line 593, in load
    sequence, frame_range = generate_sequence(h, h_dir)
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Work\REPO\ayon-unreal\client\ayon_unreal\api\pipeline.py", line 633, in generate_sequence
    fps = folder_entity["attrib"].get("fps") or 30.0
          ~~~~~~~~~~~~~^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable

here is my maya scene scrngrb:
Screenshot 2024-08-08 163927

@moonyuet
Copy link
Member

moonyuet commented Aug 9, 2024

Member

@LiborBatek can you test it again? The bug you mentioned should be fixed after updating the branch with the latest develop

@moonyuet moonyuet requested a review from LiborBatek August 9, 2024 07:00
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it correctly loads Layout product containing skeletalMesh and staticMesh coming from maya and no any errors given.

image

Note: the transforms in the UE when loaded doesnt match maya one, even tho this PR is already merged which should solve it so I guess we are missing something here still

@moonyuet
Copy link
Member

moonyuet commented Aug 9, 2024

Now it correctly loads Layout product containing skeletalMesh and staticMesh coming from maya and no any errors given.

image

Note: the transforms in the UE when loaded doesnt match maya one, even tho this PR is already merged which should solve it so I guess we are missing something here still

Implemented the fix here: ynput/ayon-maya#64

@LiborBatek LiborBatek self-requested a review August 20, 2024 07:20
@LiborBatek LiborBatek dismissed their stale review August 20, 2024 07:21

will try again after commits got merged into develop from other PRs

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My layout product from maya containing skeletalMesh and staticMesh when loaded into UE matches the orig one and both products been correctly loaded.

LGTM

image

@antirotor antirotor merged commit 8698c84 into develop Aug 23, 2024
1 check passed
@antirotor antirotor deleted the enhancement/add-staticMesh-product-to-layout branch August 23, 2024 12:52
@antirotor antirotor added the type: enhancement Improvement of existing functionality or minor addition label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants