Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the render file directory as stagingDir #204

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Dec 19, 2024

Changelog Description

Store the render file directory as stagingDir

Additional review information

Fix #194

Testing notes:

  1. Test with PR Store in instance data whether the staging dir set is a custom one ayon-core#1066
  2. With ValidateRenderImageRule plug-in enabled publishing renders should work fine.
  3. Submitting renders should work as intended with both custom staging dir set and when disabled.

@BigRoy BigRoy added the type: bug Something isn't working label Dec 19, 2024
@BigRoy BigRoy self-assigned this Dec 19, 2024
@BigRoy BigRoy marked this pull request as draft December 19, 2024 14:41
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested both without any custom staging directory on and with my custom one...in both cases no errors shown and my DL jobs finnished ok and renders got properly integrated into AYON.

LGTM!
Screenshot 2024-12-20 130215

Screenshot 2024-12-20 125849

and finally when used with staging template:

Screenshot 2024-12-20 132509

@LiborBatek
Copy link
Member

...also checked if custom staging dir was used and properly cleaned up....all good!

@antirotor antirotor merged commit 93fc4a5 into ynput:develop Dec 20, 2024
1 check passed
@iLLiCiTiT iLLiCiTiT changed the title Store the render file directory as stagingDir Store the render file directory as stagingDir Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidateRenderImageRule trigger failure after recent ayon-core staging dir update
3 participants