Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidateRenderImageRule trigger failure after recent ayon-core staging dir update #194

Closed
1 task done
kalisp opened this issue Dec 11, 2024 · 2 comments · Fixed by #204
Closed
1 task done

ValidateRenderImageRule trigger failure after recent ayon-core staging dir update #194

kalisp opened this issue Dec 11, 2024 · 2 comments · Fixed by #204
Assignees
Labels
type: bug Something isn't working

Comments

@kalisp
Copy link
Member

kalisp commented Dec 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues and added correct labels.

Description

Current Behavior

ValidateRendeerImageRule now triggers as stagingDir is filled on the instance and it doesn't match expected value from workspace.mel.

Collected value is absolute path to temp dir, expected value is renders/maya (eg it expect rendered files to be stored relatively to workfile.

Expected Behavior

Couple of approaches:

  • Logic needs to be redone
  • collection of stagingDir should be disabled for render product type in Maya
  • disabling that validator

Steps To Reproduce:

No response

Additional context:

Version

ayon-core most likely from 1.0.11

Relevant log output:

@BigRoy
Copy link
Contributor

BigRoy commented Dec 20, 2024

So unfortunately this seems non-trivial with the current API of the custom staging dir inside ayon-core.

For the validator to do what it needs to it'll need to differentiate between whether the instance's staging dir is a custom one - or the "default" one (e.g. a temporary one in tempdir). As such, I think we should be adding an additional data key in the instance.data that sets instance.data["stagingdir_custom"] = True so this validator could just query for that.

@iLLiCiTiT @antirotor thoughts? I'd be happy to make the change in ayon-core?

The alternative approach is "guessing" it's the temp one by checking if it's in temp directory or not.

@antirotor
Copy link
Member

I am not for any guessing and having this flag on instance makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants