-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Merge cli and cli_commands #802
Merged
Merged
+145
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/S
type: enhancement
Improvement of existing functionality or minor addition
labels
Jul 25, 2024
BigRoy
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to create the addon and upload it to avoid this error, from recent PR #793
2024-07-25 16:12:17: 0: STDOUT: Traceback (most recent call last):
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-core\client\ayon_core\cli.py", line 331, in main
2024-07-25 16:12:17: 0: STDOUT: main_cli(
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 1157, in __call__
2024-07-25 16:12:17: 0: STDOUT: return self.main(*args, **kwargs)
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 1078, in main
2024-07-25 16:12:17: 0: STDOUT: rv = self.invoke(ctx)
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 1688, in invoke
2024-07-25 16:12:17: 0: STDOUT: return _process_result(sub_ctx.command.invoke(sub_ctx))
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 1688, in invoke
2024-07-25 16:12:17: 0: STDOUT: return _process_result(sub_ctx.command.invoke(sub_ctx))
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 1688, in invoke
2024-07-25 16:12:17: 0: STDOUT: return _process_result(sub_ctx.command.invoke(sub_ctx))
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 1434, in invoke
2024-07-25 16:12:17: 0: STDOUT: return ctx.invoke(self.callback, **ctx.params)
2024-07-25 16:12:17: 0: STDOUT: File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\runtime\click\core.py", line 783, in invoke
2024-07-25 16:12:17: 0: STDOUT: return __callback(*args, **kwargs)
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-applications\client\ayon_applications\addon.py", line 298, in _cli_extract_environments
2024-07-25 16:12:17: 0: STDOUT: env = self.get_farm_publish_environment_variables(
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-applications\client\ayon_applications\addon.py", line 89, in get_farm_publish_environment_variables
2024-07-25 16:12:17: 0: STDOUT: return self.get_app_environments_for_context(
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-applications\client\ayon_applications\addon.py", line 52, in get_app_environments_for_context
2024-07-25 16:12:17: 0: STDOUT: return get_app_environments_for_context(
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-applications\client\ayon_applications\utils.py", line 187, in get_app_environments_for_context
2024-07-25 16:12:17: 0: STDOUT: context.run_prelaunch_hooks()
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-applications\client\ayon_applications\manager.py", line 581, in run_prelaunch_hooks
2024-07-25 16:12:17: 0: STDOUT: prelaunch_hook.execute()
2024-07-25 16:12:17: 0: STDOUT: File "E:\dev\ayon-core\client\ayon_core\hooks\pre_filter_farm_environments.py", line 26, in execute
2024-07-25 16:12:17: 0: STDOUT: project_settings["core"]["filter_env_profiles"])
2024-07-25 16:12:17: 0: STDOUT: KeyError: 'filter_env_profiles'
After that submission to deadline from fusion plus deadline render + publish worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Removed
cli_commands.py
and moved the content tocli.py
.Additional info
Content of
cli_commands.py
did shrunk to import of function and calling the function, which can happen incli.py
directly without need to maintaining 2 files.Create new function for cli publish in
ayon_core/pipeline/publish/lib.py
which does what Commandspublish
function did.Testing notes:
All commands should be working as before.
publish
command is working as expected, it is used on farm (e.g. deadline publish).