New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farm: replace in environment values requires a value #793

Merged

iLLiCiTiT merged 15 commits into develop from feature/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value

Jul 25, 2024

Member

kalisp commented Jul 22, 2024

Changelog Description

This PR provides way how to skip or update values for particular environment variables only for farm rendering.

Additional info

Environment variables on artist machines might be different than on worker machines, maybe pointing to demo license on artist machines and real license on workers etc.

Testing notes:

configure profile
ayon+settings://core/filter_farm_environment

(I added temporary variables with Project environments field for easier testing.)
publish on farm, open log of render job and look for :
Skipping for skipped env vars
value of modified env var a bit lower when env vars are set from exported .json file

kalisp added 2 commits

July 22, 2024 15:59


          Added profile to filter environment variables on farm

eda080d


          Added hook filtering farm environment variables

274ed65

Should be triggered only on farm. Used to modify env var on farm machines like license path etc.

kalisp requested review from 64qam, iLLiCiTiT and MilaKudr

July 22, 2024 14:05

kalisp assigned iLLiCiTiT

Contributor

ynbot commented Jul 22, 2024

Task linked: AY-5998 DL: Search & replace in environment values requires a Value

ynbot added size/S type: feature labels

iLLiCiTiT reviewed

View reviewed changes

server/settings/main.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

server/settings/main.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

client/ayon_core/hooks/pre_filter_farm_environments.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

client/ayon_core/hooks/pre_filter_farm_environments.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

client/ayon_core/hooks/pre_filter_farm_environments.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

server/settings/main.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

client/ayon_core/hooks/pre_filter_farm_environments.py Outdated Show resolved Hide resolved

kalisp and others added 6 commits

July 22, 2024 16:39


          Update variable name for skipped env vars

3f4a491

Co-authored-by: Jakub Trllo <[email protected]>


          Merge branch 'develop' of https://github.com/ynput/ayon-core into fea…

8a956e3

…ture/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value


          Update names of profile fields to be more descriptive

291e3ea


          Simplified methods for manipulating environments

3dc12c7


          Merge remote-tracking branch 'origin/feature/AY-5998_DL-Search--repla…

09c9ef9

…ce-in-environment-values-requires-a-Value' into feature/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value


          Fix key name from Settings

f473e98

MilaKudr approved these changes

View reviewed changes


          Remove empty environment variable

07d0bcc

kalisp requested a review from iLLiCiTiT

July 24, 2024 10:28


          Merge branch 'develop' into feature/AY-5998_DL-Search--replace-in-env…

a82118a

…ironment-values-requires-a-Value

iLLiCiTiT reviewed

View reviewed changes

server/settings/main.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

server/settings/main.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

client/ayon_core/hooks/pre_filter_farm_environments.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed

View reviewed changes

server/settings/main.py Outdated Show resolved Hide resolved

kalisp and others added 4 commits

July 25, 2024 14:33


          Change name of variable

aad7e29

Co-authored-by: Jakub Trllo <[email protected]>


          Change name of variable

6b66de7

Co-authored-by: Jakub Trllo <[email protected]>


          Change name of variable

6a4196c

Co-authored-by: Jakub Trllo <[email protected]>


          Change name of model

2003ae8

Co-authored-by: Jakub Trllo <[email protected]>

iLLiCiTiT approved these changes

View reviewed changes

64qam approved these changes

View reviewed changes

64qam approved these changes

View reviewed changes


          Merge branch 'develop' into feature/AY-5998_DL-Search--replace-in-env…

7c143ee

…ironment-values-requires-a-Value

iLLiCiTiT merged commit d31eb8a into develop

1 check passed

iLLiCiTiT deleted the feature/AY-5998_DL-Search--replace-in-environment-values-requires-a-Value branch

July 25, 2024 13:06

BigRoy mentioned this pull request

Chore: Merge cli and cli_commands #802

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S type: feature