-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workfile Templates: add event system to Workfile Template Builder #426
Merged
iLLiCiTiT
merged 8 commits into
ynput:develop
from
BigRoy:enhancement/workfile_template_event_system
Apr 30, 2024
Merged
Workfile Templates: add event system to Workfile Template Builder #426
iLLiCiTiT
merged 8 commits into
ynput:develop
from
BigRoy:enhancement/workfile_template_event_system
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynbot
added
size/XS
type: enhancement
Improvement of existing functionality or minor addition
labels
Apr 17, 2024
BigRoy
changed the title
Workfile templates: add event system to Workfile Template Builder
Workfile Templates: add event system to Workfile Template Builder
Apr 17, 2024
iLLiCiTiT
reviewed
Apr 18, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Apr 18, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Apr 18, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
…self to persist or use the `weakref_partial` implementation from the event system
… the register and trigger event methods
BigRoy
commented
Apr 18, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
This was referenced Apr 19, 2024
iLLiCiTiT
reviewed
Apr 30, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Apr 30, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Apr 30, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
iLLiCiTiT
reviewed
Apr 30, 2024
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakub Trllo <[email protected]>
iLLiCiTiT
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add an
EventSystem
to the workfile template builder for placeholder plug-ins to register to.From a placeholder plug-in you can now register to events:
Additional info
This is separated from #327 to make smaller PRs. Due to the event system being implemented here in isolation it may be hard to do a test run.
Once this is merged and #425 is merged I'll make follow-up PRs for Maya for plug-ins that actually use the event system.
Testing notes: