-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workfile Templates: Implement registering and discovering of PlaceholderPlugin
#425
Workfile Templates: Implement registering and discovering of PlaceholderPlugin
#425
Conversation
What problem does this solve? I understood you yanked out placeholder creators into separate plugins, but what we gain by that? |
Good question. We gain:
And that helps as well! :) The fact they now live 'on their own' like this also makes it much easier when reading the code what is related to each other or not. So it also cleans up the code a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested in Nuke, AE, Maya.
In Maya everything works fine, in AE and Nuke there are some issues when building workfile. But I dont think these are connected to this PR, I tested same workfile templates in develop
and issues seems to be the same.
So I think is PR is not breaking anything, but we need to revisit state of resolving of placeholders for Nuke and AE in develop.
Refactor plugin folders `template/` to `workfile_build/`
…ch other constants that do not contain `PLUGIN`
client/ayon_core/pipeline/workfile/workfile_template_builder.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ancement/workfile_templates_register_plugin # Conflicts: # client/ayon_core/hosts/maya/api/workfile_template_builder.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully in Nuke 15.
Changelog Description
Implement registering and discovering of Workfile Template Build Placeholder Plugins dynamically.
Additional info
Separated from #327
Testing notes:
Make sure workfile templates still behave as intended (basically existing templates should continue to work)
After Effects
Nuke
Maya