Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: Validate Mesh Non-Manifold improve artist report + add repair #265

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Maya: Validate Mesh Non-Manifold improve artist report + add repair #265

merged 3 commits into from
Mar 29, 2024

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 26, 2024

Changelog Description

Validate Mesh Non-Manifold improve artist report + add repair

Additional info

n/a

Testing notes:

  1. Validate Mesh Non Manifold validator should work
  2. Report should be clear
  3. Repair action should work

@BigRoy BigRoy requested a review from LiborBatek March 26, 2024 21:45
@ynbot ynbot added size/S host: Maya type: enhancement Improvement of existing functionality or minor addition labels Mar 26, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 27, 2024
MustafaJafar
MustafaJafar approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my side.
Repair action works.

image

I wish if we could change Details label into something else. I feel that Details is not pretty accurate term.

ayon-core/client/ayon_core/tools/publisher/widgets/report_page.py

Line 1532 in 199ae5f

"Details", error_details_top)

Anyway, ignore me.

LiborBatek
LiborBatek approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me too...

image

Also Repair works ok.

@tokejepsen tokejepsen merged commit 0a75032 into ynput:develop Mar 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiborBatek LiborBatek LiborBatek approved these changes

@MustafaJafar MustafaJafar MustafaJafar approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
community Issues and PRs coming from the community members host: Maya size/S type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BigRoy @MustafaJafar @LiborBatek @tokejepsen @iLLiCiTiT @ynbot