Fix OTIO range computation 23.976 fps rounding with embedded timecode #1064
+262
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-ynput
added
the
tests
robin-ynput
changed the title
iLLiCiTiT
reviewed
Jan 9, 2025
jakubjezek001
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
help resolve ynput/ayon-flame#28
Fixes another of those 23.976... fps rouding issue when computing the handles and available frame range.
Issue was initially reported on Discord.
Additional info
The failing computation had been added as unit test.
Testing notes:
.\tools\manage.ps1 run pytest .\tests\