-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Applications settings #16
Chore: Applications settings #16
Conversation
…type # Conflicts: # server/applications.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have followed the testing steps and all seems working well!
All aplications
been visible in the Launcher
when using Attributes
instead of Profiles
- so all fine on this front.
Once switched to Profiles
I was able to define aps by the profile and it correctly filtered out the aps in the Launcher
too... as seen here (my profile and launcher state afterwards)
Speaking of Tools
and Profiles
it also works well and I was able to load tools just for a particular task type...in following example for rigging
tasks and Mansur rigging tools
...of course both Aplications
and Tools
were tested for the occasions not falling in the filter set and also tested with Folder type
filter...this was causing me some confusion at the begining as I was thinking that folder type folder
being pretty much every type aka acting for all folder types but not :) ...after realizing that its actual type too all went well and predictably!
LGTM!
I would like to note something...just my thought (no deal breaker for Approval) Once user switches to Questionable being if when user creates very first |
100% no for me. You don't want to use all tools if they are empty (you usually don't want to use tools), and you may want to not show any applications for certain task types. |
@iLLiCiTiT I got ya, makes sense... one more to ask...wouldnt be lovely to use some sort of |
NOTE: There is internal discussion related to tools. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested - App filters + several profiles for different tasks types and works properly.
Didn't test Tool filters, because I don't use any tools, but assume that is also working.
Changes made:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, testing this a user, I didn't dive in the code.
So, in a nut shell, please correct me.
- We are going to filter applications using task types instead of project names.
- We are going to filter tools using folder paths and task types or task names.
Tool filter didn't work on my side.
Here's my UX feedback.
I really like how dynamic it is.
- Applications Filters:
- Tools Filters
- Folder paths: For the first glance, It looks unfamiliar. as I don't have a regex pattern that works with all of my test project.
but, then I remembered that it can be overridden in project settings anyways!
It can be overriden per project. So, technically we're adding additional filter, and you set application at one place instead of 2.
Yes.
Well, that's why it can be overriden per project. |
Probably can be changed on frontend to add search for multiselection enumerator in settings @martastain @Innders ? EDITED: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the code and just want to review the functionality.
I think this can work nicely. It works better than I expected and seems like a sensible direction.
Some caveats:
- This functionally is massively shitty without the AYON server copying studio and project settings on addon updates. Because this easily means everyone needs to manually go into all projects to tweak their project overrides, the whole time.. on every update.
- The launcher is massively slow switching tasks when
ayon+settings://applications/only_available
is enabled and a lot of applications are enabled. We have this disabled in our productions, but it's something we should improve for any new users coming to AYON with the new default of "All applications" enabled by default?
I have to agree with @BigRoy that there should be option to have all aplications enabled by default in AYON (aka no need to set filter and manually cherrypick all apps first) |
Agree, I think it is worked on right now.
I've noticed this too, I though it's because I had running too many processes. Creating issue for it.
That's what default does. |
Changelog Description
Refactored applications settings. Removed unnecessary settings from known applications like icon and label. Added option to define available applications and tools in settings instead of attributes.
Additional info
Using settings instead of attributes for available applications and tools is for now by default turned off, that is to avoid possible confusion on update and to keep opened doors if we find out possible issues with current settings.
The possible issues might be that tools cannot be set per task, but only per folder type and task type, which is more less granular approach, but at the same time easier to set up.
Removed settings for icon and label, known applications have both hardcoded in code.
Screenshot
UX enhancements
I would say that the labels in settings might need a change. As there is a lot of places whereApplications
andTools
is visible in UI.Also I've used labels from settings labels in launcher, which might be wrong? (e.g.Removed company name from application labels.Maya
becameAutodesk Maya
.)Tools now have filtering by application and host name in tools definitions. It might be also added to profiles. But I think that current model is better, as the tool define application and host name, whereas tools profiles define context where it will be used, maybe?
NOTE: This PR requires minor version bump.
Testing notes:
Change version inVersion in PR already changed topackage.py
to higher minor version (e.g.0.3.0-settings
).1.0.0-dev.1
.python ./create_package.py
and upload the package to AYON server.ayon+settings://applications/project_applications/enabled
andayon+settings://applications/project_tools/enabled
set toFalse
They are both enabled by default, but copying of settings from older version should change it. Change it toTrue
, so you can test new features.ayon+settings://applications/project_applications
and define applications that will be shown. You can add different profiles for different task types or folder types.ayon+settings://applications/project_tools
and define tools that should be used.