Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools enhancement #17

Open
iLLiCiTiT opened this issue Aug 12, 2024 · 3 comments
Open

Tools enhancement #17

iLLiCiTiT opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
type: enhancement Improvement of existing functionality or minor addition

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Aug 12, 2024

Description

PR #16 added option to define tools with profiles, but for some production cases it would be helpful to define them per task. That is also possible with the settings, using task path, but it is hard to maintain and there is no visual indication how to know "What tools will be used on this task?".

Suggested implementation

After discussion with @mkolar we've came to possible solution. Attributes were just not designed for this kind of feature. So we still use profiles as base functionality, but we'll also supply option to "override" profiles with "tools" stored to "data".

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Aug 12, 2024
@dee-ynput
Copy link

with "tools" stored to "data"

Can you elaborate on this? 🙏

@iLLiCiTiT
Copy link
Member Author

Each entity has "data", where we can store custom metadata, e.g. tools overrides. So if task entity has "tools" in "data" it means it completelly skips the profiles logic and uses overrides instead.

@iLLiCiTiT
Copy link
Member Author

This will need some frontend work first. Applications addon should add UI for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

No branches or pull requests

2 participants