Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imgur_upload() is not working #1495

Closed
jennybc opened this issue Jan 21, 2018 · 2 comments · Fixed by #1496
Closed

imgur_upload() is not working #1495

jennybc opened this issue Jan 21, 2018 · 2 comments · Fixed by #1496
Milestone
v1.19

Comments

@jennybc
Copy link
Contributor

jennybc commented Jan 21, 2018 

f = tempfile(fileext = '.png')
png(f); plot(rnorm(100), main = R.version.string); dev.off()
#> quartz_off_screen 
#>                 2
res = knitr::imgur_upload(f)
#> Error in knitr::imgur_upload(f): failed to upload /var/folders/vr/gzrbtprx6ybg85y5pvwm1ct40000gn/T//Rtmp3irMlj/file160520953d3f.png

It looks like the content returned by the POST has changed. The upload actually succeeds, but the test for success fails and the link is not being extracted. PR coming.
@jennybc jennybc mentioned this issue Jan 21, 2018
Merged
@yihui yihui added this to the v0.19 milestone Jan 22, 2018
yihui pushed a commit that referenced this issue Jan 22, 2018
@jennybc @yihui
Structure of content returned by imgur has changed (#1496)
e0334ea 
Fixes #1495
yihui added a commit that referenced this issue Jan 22, 2018
@yihui
a news item for #1495 and add Jenny to contributors
0d99e32
@jennybc jennybc mentioned this issue Jan 25, 2018
Closed
@yihui
Copy link
Owner

yihui commented Jan 29, 2018

FYI: knitr 1.19 is on CRAN now (which includes this fix).

@cderv cderv mentioned this issue Mar 14, 2018
Closed
@atakanekiz atakanekiz mentioned this issue Apr 4, 2020
Closed
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.19
Development

Successfully merging a pull request may close this issue.

Structure of content returned by imgur has changed
2 participants
@yihui @jennybc