Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

needs to import xml2 > 1.2.0 for imgur_upload #1523

Closed
cderv opened this issue Mar 14, 2018 · 2 comments · Fixed by #1525
Closed

needs to import xml2 > 1.2.0 for imgur_upload #1523

cderv opened this issue Mar 14, 2018 · 2 comments · Fixed by #1525
Milestone
v1.21

Comments

@cderv
Copy link
Collaborator

cderv commented Mar 14, 2018

I believe the #1495 was due to a breaking change in xml2 1.2.0 in as_list that now return the root node. Fix in #1496 is a way to deal with that.
However knitr now needs xml2 >= 1.2.0 for imgur_upload to work properly.

I could to a PR with that addition Un description or test in imgur_upload for which version of xml2 and do the right thing accordingly. What do you think?
@yihui
Copy link
Owner

yihui commented Mar 14, 2018 •
edited
Loading

Yes, please both update the DESCRIPTION and test packageVersion('xml2') >= '1.2.0' in imgur_upload() in your PR. Thanks!

@yihui yihui added this to the v1.21 milestone Mar 14, 2018
@cderv cderv mentioned this issue Mar 14, 2018
Merged
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.21
Development

Successfully merging a pull request may close this issue.

deals with xml2 >= 1.2.0 change cderv/knitr
2 participants
@yihui @cderv