Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate eslint docs per version changes #556

Merged
merged 7 commits into from
Nov 25, 2024
Merged

fix: migrate eslint docs per version changes #556

merged 7 commits into from
Nov 25, 2024

Conversation

asanehisa
Copy link
Contributor

@asanehisa asanehisa commented Nov 25, 2024

Bug introduced in eslint v9.15.0. Ended up not downgrading, but adding additonal rules to eslint docs per Jake's comment

Also followed this migration guide so eslint would work

@asanehisa asanehisa requested a review from a team as a code owner November 25, 2024 17:45
@asanehisa asanehisa marked this pull request as draft November 25, 2024 17:56
@asanehisa asanehisa changed the title fix: downgrade eslint 9.15.0 fix: downgrade eslint to v9.14.0 Nov 25, 2024
@asanehisa asanehisa marked this pull request as ready for review November 25, 2024 18:34
eslint.config.mjs Outdated Show resolved Hide resolved
eslint.config.mjs Show resolved Hide resolved
Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also another solution that lets us stay on 0.15:

typescript-eslint/typescript-eslint#10338 (comment) ->
eslint/eslint#19134 (comment)

@asanehisa asanehisa changed the title fix: downgrade eslint to v9.14.0 fix: migrate eslint docs per version changes Nov 25, 2024
Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@asanehisa asanehisa merged commit d8c3adf into main Nov 25, 2024
18 checks passed
@asanehisa asanehisa deleted the eslint branch November 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants