Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo make config and tests #2640

Merged
merged 6 commits into from
Apr 28, 2022
Merged

Conversation

ranile
Copy link
Member

@ranile ranile commented Apr 24, 2022

Description

This PR:

  • Removes cargo make pr-flow
  • Updates cargo make config to be more user-friendly
  • Runs test that were never, ever run

Fixes #2637
Fixes #2403

cargo-make config

  • checks-flow
    • lint
    • lint-release
    • format
  • test-flow
    • test
    • doc-test
    • website-test

packages/yew also contains clippy-feature-soundness to ensure features are used properly

@ranile ranile added the A-ci Area: The continuous integration label Apr 24, 2022
@ranile ranile requested a review from siku2 April 24, 2022 21:42
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit e29793e):

https://yew-rs-api--pr2640-cargo-make-updates-gsteg39m.web.app

(expires Sun, 01 May 2022 21:46:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

Size Comparison

examples master (KB) pull request (KB) diff
boids 173.706 173.706 0
contexts 110.693 110.693 0
counter 87.388 87.388 0
counter_functional 87.941 87.941 0
dyn_create_destroy_apps 90.438 90.438 0
file_upload 103.316 103.316 0
function_memory_game 167.822 167.822 0
function_router 353.686 353.686 0
function_todomvc 162.748 162.748 0
futures 227.099 227.099 0
game_of_life 108.423 108.423 0
inner_html 83.882 83.882 0
js_callback 113.467 113.467 0
keyed_list 196.318 196.318 0
mount_point 86.903 86.903 0
nested_list 116.409 116.409 0
node_refs 90.277 90.277 0
password_strength 1540.551 1540.551 0
portals 97.477 97.477 0
router 319.530 319.530 0
simple_ssr 500.120 500.120 0
ssr_router 429.260 429.260 0
suspense 111.166 111.166 0
timer 90.071 90.071 0
todomvc 144.101 144.101 0
two_apps 87.969 87.969 0
webgl 87.562 87.562 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cargo make pr-flow pr-flow is broken on macOS
2 participants