Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-flow is broken on macOS #2403

Closed
1 of 3 tasks
futursolo opened this issue Jan 23, 2022 · 4 comments · Fixed by #2640
Closed
1 of 3 tasks

pr-flow is broken on macOS #2403

futursolo opened this issue Jan 23, 2022 · 4 comments · Fixed by #2640
Labels

Comments

@futursolo
Copy link
Member

Problem

Not sure if this issue is related to macOS specifically.
But I haven't seen others with a different system reporting any issues.

Steps To Reproduce
run cargo make pr-flow

...

[cargo-make][2] INFO - Task: test-flow
[cargo-make][2] INFO - Profile: development
[cargo-make][2] INFO - Skipping Task: core::legacy-migration 
[cargo-make][2] INFO - Execute Command: "cargo" "test" "--all-targets" "--workspace" "--exclude" "website-test"

...

failures:

---- html::component::lifecycle::tests::lifecycle_tests stdout ----
thread 'html::component::lifecycle::tests::lifecycle_tests' panicked at 'cannot call wasm-bindgen imported functions on non-wasm targets', /Users/my-user/.cargo/registry/src/github.com-some-random-string/js-sys-0.3.55/src/lib.rs:5412:9
stack backtrace:

...

Expected behavior
pr-flow runs.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

  • Yew version: master
  • Rust version: 1.58
  • Target, if relevant: not relevant
  • Build tool, if relevant: not relevant
  • OS, if relevant: macOS
  • Browser and version, if relevant: not relevant

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@ranile
Copy link
Member

ranile commented Feb 12, 2022

I'm wondering if we should even have pr-flow. CI is enough to test it. It's just unnecessary step to run on contributor's computer

@futursolo
Copy link
Member Author

I actually have already had it fixed as I need to run tests.

I will file a pull request to fix it (alongside the thing I intend to add).

@futursolo futursolo mentioned this issue Feb 12, 2022
3 tasks
@ranile
Copy link
Member

ranile commented Feb 12, 2022

I always run tests by just running cargo test or wasm-pack test in the crate that I'm working on. That allows me to just run yew tests when I work on yew, without forcing me to also run clippy, router tests, etc

@futursolo
Copy link
Member Author

I don't disagree and I do prefer that if possible. But, ... I can never remember the correct command in the correct directory?

e.g.: wasm-pack test --firefox --headless -- --features wasm_test --test hydration in packages/yew

I wish tests can be as simple as cargo test --all --all-features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants