Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web_sys re-export #2084

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Conversation

mc1098
Copy link
Contributor

@mc1098 mc1098 commented Sep 24, 2021

Description

Removes re-exporting the web_sys dependency from the yew crate and
removes some web_sys features that were only enabled for re-exporting.

Fixes #0000

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests N/A

Removes re-exporting the `web_sys` dependency from the yew crate and
removes some `web_sys` features that were only enabled for re-exporting.
@github-actions
Copy link

github-actions bot commented Sep 24, 2021

Visit the preview URL for this PR (updated for commit ac11278):

https://yew-rs--pr2084-remove-web-sys-expor-avzscbo1.web.app

(expires Sat, 02 Oct 2021 14:33:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@mc1098 mc1098 mentioned this pull request Sep 25, 2021
2 tasks
@siku2
Copy link
Member

siku2 commented Sep 25, 2021

I only wanted to remove the web_sys crate re-export, not the individual event types. If you think we should remove those too that's fine by me, I just want to make sure we don't misunderstand each other here.

@ranile
Copy link
Member

ranile commented Sep 25, 2021

I feel like we should re-export the types that are exposed in the public API. For example, event types that are used in Callbacks can be re-exported by yew::events

@mc1098
Copy link
Contributor Author

mc1098 commented Sep 25, 2021

I just want to make sure we don't misunderstand each other here.

I did misunderstand :) and I can update this

It's probably to no benefit to remove them in hindsight, any issues with compatibility would occur even if the event types weren't re-exported by Yew - we still add them as a feature in Yew so it doesn't effect the wasm size unless Yew specifically got into the feature gate game with events which I'm not advocating for btw :)

@mc1098 mc1098 added the A-yew Area: The main yew crate label Sep 26, 2021
@mc1098
Copy link
Contributor Author

mc1098 commented Sep 26, 2021

Events are back :)

@siku2 siku2 merged commit e503c9a into yewstack:master Sep 27, 2021
@mc1098 mc1098 deleted the remove-web-sys-export branch September 29, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants