-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-export web_sys
for user convenience
#568
re-export web_sys
for user convenience
#568
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 61.21% 61.21%
=======================================
Files 55 55
Lines 9021 9021
=======================================
Hits 5522 5522
Misses 3499 3499
☔ View full report in Codecov by Sentry. |
Maybe I'm missing something, but given |
I agree with this sentiment about web-sys. It might make sense to re-export js-sys and wasm-bindgen, although I'm personally a bit iffy on this as well. Yew used to have a web-sys re-export but they removed it: yewstack/yew#2084 |
I think sycamore should only re-export types that are also used in public signatures of sycamore's types and traits. |
Hi there, sorry for ignoring this for such a long time. I think what I would like to do is to have sycamore re-export |
Closed in favor of #642. @blainehansen I've included the original commits from this PR to give you credit. |
I found myself needing to annotate a handler event type, and didn't want to specify my own dependency on
web_sys
. This pull request should make patterns like the below easy:I also added
js_sys
. Are there any other libraries we should re-export? Is there any value in re-exportingwasm_bindgen
for example?