Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update individual score reports #500

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

lucasxsong
Copy link
Collaborator

Copy link

github-actions bot commented Apr 10, 2024

Visit the preview URL for this PR (updated for commit 7696925):

https://roar-staging--pr500-fix-individual-repor-7jdx7fhd.web.app

(expires Thu, 18 Apr 2024 17:13:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Apr 10, 2024

1 flaky test on run #1117 ↗︎

0 34 0 0 Flakiness 1

Details:

Tests for PR 500 "update individual score reports" from commit "7696925c3af9e466...
Project: roar-dashboard-e2e Commit: 7696925c3a
Status: Passed Duration: 36:13 💡
Started: Apr 11, 2024 5:15 PM Ended: Apr 11, 2024 5:51 PM
Flakiness  cypress/e2e/participant/default-tests/playButtonGames.cy.js • 1 flaky test

View Output

Test Artifacts
Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Picture Vocabulary Play through Test Test Replay Screenshots

Review all test suite changes for PR #500 ↗︎

Copy link
Contributor

@richford richford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, all but one test are passing, and I have visually confirmed that this satisfies the requests in https://github.com/yeatmanlab/roar/issues/246.

However, I did notice that some Propel students are marked as having unreliable runs when I didn't expect it. For example, can you take a look at PID pro-gr6+-fd79e334. They have unreliable runs listed in their individual score report. But their scores are not highlighted as unreliable in the group score report. Their runs on firestore are marked as unreliable but they do not have any flags. What gives.

This is a problem on production too so it should not block this PR. I'm approving.

@lucasxsong lucasxsong merged commit 423fbff into main Apr 11, 2024
13 of 14 checks passed
@lucasxsong lucasxsong deleted the fix/individual-report-updates branch April 11, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants