Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage reprobing #484

Merged
merged 9 commits into from
Mar 24, 2023

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Mar 20, 2023

Problem

Support for configuring iSCSI targets was already added, and DASD is coming soon. But the system is not re-probed after activating/deactivating devices, which implies the new disks cannot not be selected for installation. Moreover, the current selected disk could not be available anymore, for example, if an iSCSI session is closed.

Solution

Add a mechanism for reprobing after changing the system. Now, if an iSCSI session is created or closed, the system is marked as deprecated. That information can be used for clients to know if a reprobing is needed. The web UI automatically executes a reprobing when the system becomes deprecated.

Note: re-probing always reuse the settings from the previous storage proposal in order to keep the configuration set by the user. And the settings are reset if the product changes (a new product must always start from scratch).

Issue to reevalute this approach: #498.

Testing

  • Added new unit tests
  • Tested manually

- Probing storage always reuses the previous proposal settings, if any.
- Styles should be moved to a class
- Note: there is an error message if the candidate device is not found
- The default device was not selected when the candidate device is
  missing.
- Components are mounted twice, which poduces some side effects as
  calling to probe system twice.
@joseivanlopez joseivanlopez marked this pull request as ready for review March 23, 2023 16:58
@coveralls
Copy link

coveralls commented Mar 23, 2023

Coverage Status

Coverage: 75.643% (+0.08%) from 75.56% when pulling 1e91826 on joseivanlopez:storage-reprobing into fa8c5d6 on yast:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants