iSCSI UI #435
Merged
iSCSI UI #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
iscsi-ui
branch
3 times, most recently
from
911c479 to
eb4269d
Compare
joseivanlopez
force-pushed
the
iscsi-ui
branch
2 times, most recently
from
5c78dd5 to
74f0681
Compare
dgdavid
reviewed
Mar 14, 2023
dgdavid
reviewed
Mar 14, 2023
dgdavid
reviewed
Mar 14, 2023
dgdavid
reviewed
Mar 15, 2023
dgdavid
reviewed
Mar 15, 2023
dgdavid
reviewed
Mar 15, 2023
joseivanlopez
force-pushed
the
iscsi-ui
branch
5 times, most recently
from
c6810d1 to
ef9cb41
Compare
dgdavid
approved these changes
Mar 16, 2023
Comment on lines
+29
to
+49
| const RowActions = ({ actions, id, ...props }) => { | ||
| const actionsToggle = (props) => ( | ||
| <DropdownToggle | ||
| id={id} | ||
| aria-label="Actions" | ||
| toggleIndicator={null} | ||
| isDisabled={props.isDisabled} | ||
| onToggle={props.onToggle} | ||
| > | ||
| <Icon name="more_vert" size="24" /> | ||
| </DropdownToggle> | ||
| ); | ||
|
|
||
| return ( | ||
| <ActionsColumn | ||
| items={actions} | ||
| actionsToggle={actionsToggle} | ||
| {...props} | ||
| /> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Reminder: As discussed off-line, in future iterations we should extract this to a common component or similar. It's used here, at users and in another place I do not remember right now.
There was a problem hiding this comment.
It is implemeted by ConnectionsTable, FirstUser, RootAuthMethods, InitiatorPresenter and NodesPresenter.
dgdavid
reviewed
Mar 16, 2023
| }; | ||
|
|
||
| export default function DiscoverForm({ onSubmit: onSubmitProp, onCancel }) { | ||
| const [savedData, setSavedData] = useLocalStorage("dinstaller-iscsi-discovery", {}); |
There was a problem hiding this comment.
NP: most probably, we should place the prefix globally
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The storage client was already adapted for dealing with the iSCSI D-Bus API recently shipped by the storage sevice, see:
But there is no UI yet for configuring iSCSI.
Solution
Add a new page for configuring iSCSI.
Testing
NOTE: The UI was heavily tested in a manual way. Unit tests will come soon in a separate PR, once we have finished more urgent tasks.
Screenshots
Show/Hide