Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reprobe storage on network devices changes #434

Closed
joseivanlopez opened this issue Feb 17, 2023 · 1 comment
Closed

Reprobe storage on network devices changes #434

joseivanlopez opened this issue Feb 17, 2023 · 1 comment
Labels
enhancement New feature or request research

Comments

@joseivanlopez
Copy link
Contributor

joseivanlopez commented Feb 17, 2023

Now D-Installer is able to configure iSCSI devices. And more technologies like FCoE is expected to be added too. With the current implementation, the storage devices are not automatically probed when an iSCSI session is created or closed. This is specially problematic when a session is closed and the storage proposal was using such a device.

Most likely we will need a button for reprobing in the UI, but still we need to add some kind of proposal validation to avoid continuing with the installation if the proposal is using an invalid device.

A possible solution might be to check whether the candidate devices are still present in the system. For that, we need to ask to libstorage-ng for reprobing the system. Ideally, such a reprobing should be performed without changing the current devicegraphs. Otherwise, we need to recalculate the proposal everytime we want to validate it. Libstorage-ng already provides a light probe, but that method only returns whether some devices where found in the system. We need it to return some more information, for example the SSID of the detected devices.

Having such an special probing, our validation would consist on checking whether the SSID of the cadidate devices are still in the list of SSIDs provides by the fast probing. This solution would be generic enough for any technology that implies adding and removing devices.

@ancorgs
Copy link
Contributor

ancorgs commented Mar 24, 2023

We plan to improve this (see #498), but #484 is good enough for closing this.

@ancorgs ancorgs closed this as completed Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request research
Projects
None yet
Development

No branches or pull requests

2 participants