Fix slashes handling in registry name #774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +46,7 @@ export default class NpmRegistry extends Registry { | |||
| } | |||
|
|
|||
| request(pathname: string, opts?: RegistryRequestOptions = {}): Promise<?Object> { | |||
| const registry = removeSuffix(String(this.registries.yarn.getOption('registry')), '/'); | |||
There was a problem hiding this comment.
instead of removing this line, it might be better to keep it and change the url.resolve line as
`${registry}/${pathname}`
chicoxyzzy
force-pushed
the
dont_remove_slash
branch
from
5bb2cb8
to
626b268
Compare
chicoxyzzy
changed the title
|
Can you add a test for this behavior? |
|
Sure. I'll add some tests this evening. |
|
Just noticed there was another PR #712 and it was merged (no tests tho so I'll add them) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some registry names need trailing slash. So this PR fixes issue described in #606 (comment)
Test plan
yarn