Custom Registry url.resolve Issue #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures with and without trailing / registry url is correct and resolvable.
|
Awesome, thank you! |
devongovett
added a commit
to devongovett/yarn
that referenced
this pull request
Oct 12, 2016
* Broken by yarnpkg#712, which changed from url.resolve to url.format. We need resolve in the case where the pathname is really a full url (when requesting tarballs). So only add the trailing / if it is not there. * Only add authorization if the request is going to the registry (not random tarballs).
devongovett
added a commit
to devongovett/yarn
that referenced
this pull request
Oct 15, 2016
* Broken by yarnpkg#712, which changed from url.resolve to url.format. We need resolve in the case where the pathname is really a full url (when requesting tarballs). So only add the trailing / if it is not there. * Only add authorization if the request is going to the registry (not random tarballs).
sebmck
pushed a commit
that referenced
this pull request
Oct 15, 2016
* Get npm registry and auth from .npmrc file * Fetch tarball through registry Needed if the registry requires auth to get tarballs * Support .npmrc auth for write commands * Support basic auth * Attempt to fix flow * Implement default request method for BaseRegistry Needed for tarball fetching now that it is going through the registry * Fix flow bug * Clean up * Fix requestUrl * Broken by #712, which changed from url.resolve to url.format. We need resolve in the case where the pathname is really a full url (when requesting tarballs). So only add the trailing / if it is not there. * Only add authorization if the request is going to the registry (not random tarballs). * Check scoped always-auth option * Remove unused function (bad rebase)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures with and without trailing / registry url is correct and resolvable.
Currently if you set a npm registry via config to be:
yarn config set registry https://mycustom.registry.com/dev/registryyarn add redux(not in cache / fresh install)The
url.resolvewill turn the url to behttps://mycustom.registry.com/dev/redux(noregistryas part of the path due to/being removedremoveSuffix.)Test plan(s)
yarn config set registry https://mycustom.registry.com/dev/registryyarn add reactyarn config set registry https://mycustom.registry.com/dev/registry/yarn add reduxyarn config set registry https://registry.npmjs.org/yarn add react-routerNote:
There appears to be a flow issue with
url.formatcurrently:facebook/flow#908
https://nodejs.org/api/url.html#url_url_format_urlobject