Fix "typesVersions" support in plugin-compat typescript patch #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cspotcode
added a commit
to cspotcode/tsdx
that referenced
this pull request
Dec 5, 2020
- Update yarn2 to build from yarnpkg/berry#2215, which fixes bug in yarn2's typescript patch - adding 2x missing dependencies which were being picked up due to node_modules hoisting
This was referenced Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Imports of the form
@jest/types/build/Config(with a sub-path within the target paackage) do not respect a "typesVersions" configuration in its package.json. For example https://unpkg.com/@jest/[email protected]/package.jsonFixes #2223
How did you fix it?
Fixed via this modification to the typescript patch.
arcanis/TypeScript#5
Checklist