-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github action for building EXE #173
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: Make self-contained Windows EXE | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: | ||
| tags: | ||
| - v* | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: windows-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup Java runtime | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: zulu | ||
Abbe98 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| java-version: 17 | ||
| java-package: jdk+fx | ||
| - name: Build with Ant | ||
| run: ant -noinput -buildfile build.xml compile jar | ||
| - name: Fetch 7-zip SFX | ||
| run: | | ||
| curl -LO https://www.7-zip.org/a/lzma2201.7z | ||
| 7z e '-i!bin/7zSD.sfx' lzma2201.7z | ||
| - name: Download Java runtime for executable | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: zulu | ||
| java-version: 17 | ||
| java-package: jre+fx | ||
| - name: Create archive | ||
| run: | | ||
| mkdir pattypan-exe | ||
| cp -r ${{ env.JAVA_HOME }} pattypan-exe/java | ||
| cp pattypan.jar pattypan-exe | ||
| cp windows/run.bat pattypan-exe | ||
| cd pattypan-exe | ||
| 7z a -mx1 ../pattypan.7z * | ||
| - name: Create executable | ||
| run: cmd /c copy /b 7zSD.sfx + windows\7z-sfx.cfg + pattypan.7z pattypan.exe | ||
| - name: Make release | ||
| uses: softprops/action-gh-release@v1 | ||
| with: | ||
| files: pattypan.exe | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| ;!@Install@!UTF-8! | ||
| Title="Pattypan" | ||
| RunProgram="run.bat" | ||
| ;!@InstallEnd@! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| java\bin\java.exe -jar pattypan.jar |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me like it should run on UNIX(with some minor changes) as long as the Java distribution doesn't strip Windows specific stuff? 7-zip SFX build should be fine on Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case it runs on Linux we could move the various steps to a Shell file so that we don't end up with proprietary dependencies and gets local reproducibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a review action here or are these just notes for how this could be developed further?