Add Github action for building EXE #173
Conversation
sebastian-berlin-wmse
changed the title
There was a problem hiding this comment.
It looks good overall!
I would like to see to what extend the dependencies on Github and Windows are actually needed. Given that it's based on SFX archives I don't see why the approach shouldn't work on Linux.
Aside from the cost and dependency aspects, a future opportunity if it works on Linux could be to make all builds with a single script or in a container if need be.
README.md
Outdated
|
|
||
| ---- | ||
| * Download the EXE file from downloads linked above. |
There was a problem hiding this comment.
This type of installation instructions currently live on Commons:Pattypan.
There was a problem hiding this comment.
Do you mean they shouldn't be in the repo? If so I can remove them and add them to the wiki once this is merged. Looks like https://commons.wikimedia.org/wiki/Commons:Pattypan/Simple_manual is a natural place to have them.
There was a problem hiding this comment.
Done.
|
|
||
| jobs: | ||
| build: | ||
| runs-on: windows-latest |
There was a problem hiding this comment.
It looks to me like it should run on UNIX(with some minor changes) as long as the Java distribution doesn't strip Windows specific stuff? 7-zip SFX build should be fine on Linux.
There was a problem hiding this comment.
In case it runs on Linux we could move the various steps to a Shell file so that we don't end up with proprietary dependencies and gets local reproducibility.
There was a problem hiding this comment.
Was there a review action here or are these just notes for how this could be developed further?
|
I would like to look into porting it to linux/bash but I'm a little short
on time currently.
…On Tue, Apr 11, 2023 at 12:13 PM sebastian-berlin-wmse < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ant.yml
<#173 (comment)>:
> @@ -0,0 +1,45 @@
+name: Make self-contained Windows EXE
+
+on:
+ workflow_dispatch:
+ push:
+ tags:
+ - v*
+
+jobs:
+ build:
+ runs-on: windows-latest
Was there a review action here or are these just notes for how this could
be developed further?
—
Reply to this email directly, view it on GitHub
<#173 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUCQJYRAVWVF37FSMD6QNDXAUVFPANCNFSM6AAAAAAWCO4WEY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
OK, so that's a possible further development and not something to do for this PR, right? This is specifically for Windows. |
|
I would like to build Windows binaries on Linux. Actions aren't an option
as explained elsewhere, however, we could probably make a new release given
the commands in this merge request.
…On Wed, Apr 12, 2023 at 8:45 AM sebastian-berlin-wmse < ***@***.***> wrote:
OK, so that's a possible further development and not something to do for
this PR, right? This is specifically for Windows.
—
Reply to this email directly, view it on GitHub
<#173 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUCQJ6JXID523B6R6BELZLXAZFQNANCNFSM6AAAAAAWCO4WEY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Hi @Abbe98, It's a bit unclear to me what exactly the issues are. If I’m understanding them correctly there are two separate ones. To build the Windows stand-alone .exe file the Action job needs to run on Windows (which is proprietary). Using Github Actions costs minutes (and Windows even more so) which is a limited resource for you (per #152 (comment)). Is this understanding correct? For 1) I believe @sebastian-berlin-wmse answered this in #152 (comment). I.e. the .exe needs to be created in the same OS as the result should be run on (since it doesn’t create an installer but a directly executable version of Pattypan). This would mean that even were you to run this locally you would need Windows. For 2) This Action should only ever run when there is a new release. Which historically is not very often. The job takes around 2 minutes (so 4 minutes with the Windows multiplier). If it is run on this repo then those minutes should be taken from Yarl’s pool of free minutes right? Either way we’d like to find a way forward on this since there is now a real use case for these executables and the most natural place for them to live is attached to the official repo. Cheers, |
Bug: #152