feat: exit early on invalid k8s version flag #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, small and nice improvement :) I might add a small acceptance test before merging this. |
The in page link to the CustomResourceDefinition (CRD) Support section is not working
* 196: qemu * 196: multi-arch; see also https://blog.devgenius.io/goreleaser-build-multi-arch-docker-images-8dd9a7903675
- Add missing 'junit' and 'pretty' output formats. - Use quotes vs. backticks around command name
This is an alternative way to fix yannh#130. Instead of changing the `group` variable content, this commit adds a new variable `fullgroup` that does not split the group components. With this, users can specify the filename format like: FILENAME_FORMAT='{fullgroup}-{version}-{kind}'
This is a follow-up to yannh#219 to add a short description on how to use the `fullgroup` variable.
|
I realised it behaves slightly differently than when passing an incorrect -schema-location - in which case it doesn't print the help, and now I am trying to see if I can implement this using the new flags.TextVar which seems like it could provide an elegant solution, but I've not played with this before 🙈 |
|
Raaaah git be damned I guess I messed up somewhere when rebasing, sorry :( Can you check the last 2 commits and lmk what you think? |
|
LGTM, Thanks! |
|
merged #254 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit early if provided kubernetes version is not in expected format.
Resolves #119