Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for 196: Multi-architecture image #204

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Fix for 196: Multi-architecture image #204

merged 2 commits into from
Jun 7, 2023

Conversation

denisa
Copy link
Contributor

@denisa denisa commented May 15, 2023

Compare (on a m1 mac mini)

> docker run ghcr.io/yannh/kubeconform:v0.6.1 -v            
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
v0.6.1

with

> docker run ghcr.io/denisa/kubeconform:v0.6.3-dna.7 -v      
v0.6.3-dna.7

Note that I followed GoReleaser build multi arch Docker Images for the latest tag.

@denisa denisa mentioned this pull request May 15, 2023
Closed
@denisa
Copy link
Contributor Author

denisa commented May 19, 2023

@yannh … any comments?

@yannh
Copy link
Owner

yannh commented May 19, 2023

Haven' t forgotten 🙇 I' ll take a look over the week end 👍

@denisa
Copy link
Contributor Author

denisa commented Jun 2, 2023

Ping?

@yannh
Copy link
Owner

yannh commented Jun 7, 2023

Let's give this a shot 👍 Linux/arm64 is the platform used for Macs M1/M2s though, really? 🙈

@yannh yannh merged commit c8bce62 into yannh:master Jun 7, 2023
@yannh yannh mentioned this pull request Jun 7, 2023
Closed
@yannh
Copy link
Owner

yannh commented Jun 7, 2023

Released v0.6.2, give it a shot? I'm wondering if it makes sense to still have architecture-dependent tags if the images are multi-arch 🤔
image

yannh pushed a commit to levenleven/kubeconform that referenced this pull request Jul 9, 2023
@denisa @yannh
Fix for 196: Multi-architecture image (yannh#204)
8ec7dd0 
* 196: qemu

* 196: multi-arch; see also https://blog.devgenius.io/goreleaser-build-multi-arch-docker-images-8dd9a7903675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisa @yannh