Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ASGI server #75

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Implement ASGI server #75

merged 1 commit into from
Jun 1, 2023

Conversation

davidbrochart
Copy link
Collaborator

Closes #37

@davidbrochart davidbrochart marked this pull request as draft June 1, 2023 08:10
@davidbrochart davidbrochart force-pushed the asgi branch 5 times, most recently from 96b9dda to 6fd1ddc Compare June 1, 2023 13:14
@davidbrochart davidbrochart marked this pull request as ready for review June 1, 2023 13:14
@davidbrochart davidbrochart merged commit 49a4530 into y-crdt:main Jun 1, 2023
@davidbrochart davidbrochart deleted the asgi branch June 1, 2023 21:07
@ToniRV
Copy link

ToniRV commented Aug 8, 2023

@davidbrochart, how would you use this with FastAPI as the ASGI server?

@davidbrochart
Copy link
Collaborator Author

I am in vacation and have limited access to the Internet, but I'll try to answer your question soon.
Don't hesitate to ping me in case I don't get back to you, say in two weeks.

@ToniRV
Copy link

ToniRV commented Aug 8, 2023

Hi @davidbrochart, no worries, I found my way, somehow 😅

By the way, I'm trying to build a ypy-mongodb, looking at your implementation of ystore for sqllitedb.
I could follow your approach there and do the same with pymongo, right?

That said, any help would be super welcome since I'm reverse engineering stuff and have little knowledge of Yjs or Ypy.
I'll ping you if I have more questions (is there a better way to reach out?), want to respect your vacation time as well.

@davidbrochart
Copy link
Collaborator Author

I could follow your approach there and do the same with pymongo, right?

Yes, actually I think the Y stores should not depend on ypy-websocket (see #19), as they could be used in other contexts.
But yes you could look at the SQLiteYStore to implement a Y store for MongoDB.
I should add more documentation, but feel free to ask for help, maybe on a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASGI compatible server
2 participants