Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASGI compatible server #37

Closed
rmorshea opened this issue Oct 21, 2022 · 7 comments · Fixed by #75
Closed

ASGI compatible server #37

rmorshea opened this issue Oct 21, 2022 · 7 comments · Fixed by #75

Comments

@rmorshea
Copy link

rmorshea commented Oct 21, 2022

This would be more useful if the server were compatible with the ASGI spec. If it were, ypy-websocket could immediately be used in conjunction with popular web servers like Starlette, FastAPI, and Sanic.

@davidbrochart
Copy link
Collaborator

I agree, on the other hand ypy-websocket is used in Jupyter Server, which still uses Tornado, but there could probably be an adapter to make it work there.
Do you want to take a stab at it? Your contribution would be greatly appreciated!

@rmorshea
Copy link
Author

It would probably be some time before I get to it, but yes, when I get around to reactive-python/reactpy#826 I'd start work on this.

@linspw
Copy link

linspw commented Apr 26, 2023

Hello everything is fine?
This ASGI support would help a lot, I'm trying to use this lib somehow in conjunction with django channels.
If it had the implementation in ASGI it would help a lot.

I would like to contribute, but I have no idea how to create an adapter in this sense.

@davidbrochart
Copy link
Collaborator

Hi @linspw,
I've not looked at it yet, but feel free to contribute. Maybe @rmorshea has ideas?

@rmorshea
Copy link
Author

I don't think I'm going to get to this any time soon.

@davidbrochart
Copy link
Collaborator

I'm not very familiar with ASGI, does anyone know if this would have to be implemented from scratch or if it would be better to use e.g. Starlette?

@davidbrochart
Copy link
Collaborator

I started this work in #75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants