-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Fable support in Nuget package #56
base: master
Are you sure you want to change the base?
Conversation
Does Fable.Aether package not work for you?
|
I think that it makes sense to have it in the original library. |
I would also like to see Fable support in the main package. Since I am sharing code between client and server, this would make it easier to keep everything in sync. |
Sharing the code would work just fine, but sharing the project dependencies
is something completely different.
|
What do you mean? For example I’m sharing the dependency for https://github.com/demystifyfp/FsToolkit.ErrorHandling and it works just fine. |
I am sharing code between client and server. This shared code depends on Aether. Currently I am depending on the file directly from GitHub using Paket's GitHub feature ( |
If I'm reading you right you are sharing the code by reusing the project, in which case yes, you have a problem. But imo more typical way to share the code is to include the same sources into different projects. This has been the traditional way of dealing with different target platforms since the days we had to take different dependencies based on x32 and x64. If you look at elmish for example, there are 2 projects - one for CLR and one for fable. Conditional compilation actually produces different implementations, so even if you could use the same package, it would not have the optimal functionality for both targets. Not saying Aether package shouldn't include the sources (see #52) but there are alternatives. |
Please, is there any update on this? I would appreciate this PR to be merged as well. There is no harm to do so - old code will work and this library could be also used from Fable without any "wrapper" like |
Hello, this change should enable the Aether to be used from Fable applications