Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include source files in package for Fable support #52

Closed
wants to merge 1 commit into from
Closed

Include source files in package for Fable support #52

wants to merge 1 commit into from

Conversation

stroborobo
Copy link

@stroborobo stroborobo commented Mar 29, 2019

Hey there!

The Fable FAQ asks to add the source files to the NuGet package: https://fable.io/faq/#library-authors
Not sure how to test this properly, tbh, but the library itself does work fine if copied into a Fable project.

@stroborobo
Copy link
Author

In case you're not familiar with Fable, here's a little application for testing this:
https://github.com/stroborobo/FableAetherTest

If you remove the Aether.fs from the fsproj, the build fails with messages like "Cannot resolve Aether [...]"

@et1975
Copy link

et1975 commented Mar 29, 2019

I already publish a build of Aether for Fable, if you need some changes maybe PR my repo instead?

@stroborobo
Copy link
Author

@et1975 Oh nice! Would there be an advantage in not having this in the original package?

@panesofglass
Copy link
Contributor

@et1975 should we merge the two together? I'm happy to make it happen.

@et1975
Copy link

et1975 commented Mar 29, 2019

Technically, Aether fitting into a single file doesn't need a package, one could (and some people do) import it at the source level directly into their app.

Reasons to keep Fable build in a separate project, all kinda weak:

  • Fable has changed its lib packaging requirements twice in my memory (some packages are still only on npm)
  • Due to JS runtime Fable's generics are non-reified and that leads to occasional hacks in the code (so it may diverge).
  • Tests of generated JS code.

If you want I can transfer the repo to xyncro, or whatever... I'm OK with whatever you have in mind @panesofglass.

@stroborobo
Copy link
Author

I'll just close this then, not a significant change anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants