This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
use select field for ratings if IE11 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kienstra You can give this a test. Thanks. |
kienstra
suggested changes
May 7, 2018
There was a problem hiding this comment.
Works Well, Very Minor Point
Hi David,
Thanks for this good solution to IE 11 support. And thanks for reviewing #80 right away, after your workday.
There's a very minor point here.
Ratings on the single 'adventure' page now work on IE 11:
includes/functions.php
Outdated
| * Add select rating field to comments. | ||
| */ | ||
| function amp_travel_comment_select_rating_field() { | ||
| echo '<p class="comment-form-rating-select"><label for="rating">' . esc_html( 'Your rating' ) . '</label> |
There was a problem hiding this comment.
Could this be:
esc_html__( 'Your rating', 'travel' )
|
@kienstra Thanks, changes applied and conflicts resolved. |
kienstra
approved these changes
May 8, 2018
|
Thanks, @DavidCramer! This looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the star rating on IE11 as mentioned in #8