Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

As a Travel website user, I need a rating to understand review scores on a given post #8

Open
postphotos opened this issue Mar 23, 2018 · 8 comments
Assignees

Comments

@postphotos
Copy link

No description provided.

@postphotos postphotos added the CPT label Apr 10, 2018
@miina miina self-assigned this Apr 17, 2018
@miina
Copy link
Contributor

miina commented Apr 17, 2018

Note that this will be resolved within #39.

@kienstra
Copy link
Contributor

kienstra commented Apr 27, 2018

Request For Testing

Hi Claudio,
Could you please test this?

  1. You can make a comment with a rating on a single adventure page
  2. That rating appears as part of the averaged rating at the top of the page, and the search page
  3. Ratings appear per the designs

@csossi
Copy link

csossi commented May 5, 2018

Rating section captures moveover/click as user moves cursor from right to left rather than left to right in IE11 (all other browsers fine):
image

Recommending more space between fields and label below it:
image

Star ratings crowd into the share icons on mobile (this image is from an Android7.0 device - happening on iPhone as well):
screenshot_20180505-105056

@DavidCramer
Copy link
Contributor

The star rating is actually not supported in IE11. I did not know this as it was not mentioned in the example https://ampbyexample.com/advanced/star_rating/

@kienstra I think we should have it switch to the old select box if IE11 is detected.

@kienstra
Copy link
Contributor

kienstra commented May 6, 2018

Star Rating In IE11

Hi @DavidCramer,
Good idea to use the old <select> for ratings in the output function if it detects IE11. I think the global $is_IE should be good for this, as 11 is the only version of IE that WordPress supports. And it worked locally, when testing this with IE11.

Do you have time to implement this? Thanks, David.

@kienstra
Copy link
Contributor

kienstra commented May 6, 2018

Thanks For Testing

Hi @csossi,
Thanks for catching these issues.

Star ratings crowd into the share icons on mobile (this image is from an Android7.0 device - happening on iPhone as well):

Thanks, we'll work on a fix for that.

Recommending more space between fields and label below it:

Good point. PR #80 (awaiting merge) should handle that.

@kienstra kienstra assigned DavidCramer and unassigned miina May 6, 2018
@DavidCramer
Copy link
Contributor

@kienstra Ye, I can do it today. Will be pretty easy.

@kienstra
Copy link
Contributor

kienstra commented May 8, 2018

Status

Thanks to @DavidCramer's PR #81, all of the points here are applied, expect for:

Star ratings crowd into the share icons on mobile (this image is from an Android7.0 device - happening on iPhone as well):

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants