Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

35 - Home styling responsiveness #62

Merged
merged 7 commits into from
Apr 26, 2018
Merged

Conversation

mehigh
Copy link
Member

@mehigh mehigh commented Apr 21, 2018

The main differences I've noticed when comparing the figma with the ampstart were around two elements:

  • the browse by activity icons on mobile should wrap on a second line and shrink. I've applied a 70% shrink on the icons when going below the medium breakpoint and also decreased the margin to only 33% of the origina.
  • the top adventures near you, which shared the layout with the similar adventures element on the single product page -> when shrinking the browser the slant is no longer present and the adventures stack instead of being horizontally scrollable

This PR makes the necessary adjustments to the respective Gutenberg blocks and adds the necessary CSS.

@miina
Please check this, and if needed, add the mark-up updates to other locations (if there are any other of course).

mehigh added 4 commits April 22, 2018 00:09
- removed div.overflow-scroll
- added travel-overflow-wrap class and swapped flex by lg-flex on the child div of travel-overflow-container
Removed overflow container, added flex-wrap such that icons flow onto a second line
@miina
Copy link
Contributor

miina commented Apr 23, 2018

Hey, @mehigh, it looks like the markup changes are currently for Gutenberg editor only and not for the actual frontend rendering, was this the intention?
There are some new issues with the editor design now:
screen shot 2018-04-23 at 10 51 13 am

The Popular block goes "behind" the right bar now, however it's not possible to see the part that's behind the bar. Previously it was possible to scroll left and right on the block to see all the posts, and the posts didn't go behind the sidebar. Same happens with the Activity List block.

Let me know if the changes were actually meant for front-end, then I'll move them over.

@miina miina changed the title 35 - Home styling responsiveness [WIP] 35 - Home styling responsiveness Apr 23, 2018
@miina
Copy link
Contributor

miina commented Apr 23, 2018

@mehigh When you pick this up on Wednesday, do you think you could also check these two small issues on the homepage:
screen shot 2018-04-23 at 2 15 19 pm

  • The location icon is on top of the input placeholder (this shows correctly on develop, perhaps it's showing correctly for you locally and it's only my issue since you actually did't make related changes?);
  • The plane icons should be on the left of the input text, not above (this is incorrect on develop, too);

Thank you!

@mehigh
Copy link
Member Author

mehigh commented Apr 25, 2018

The search icon misplacement was caused by a calc() rule containing vars which was getting stripped out by the amp plug-in. I've updated the calc / var rule inside of the sources and recompiled amp-start to get this going.

@mehigh
Copy link
Member Author

mehigh commented Apr 25, 2018

The icons misalignment with the start and end dates was caused by 3 other calc instances which used vars. Those were getting stripped out, so I computed and placed in the proper em values.

screen shot 2018-04-25 at 22 52 33

@mehigh mehigh requested a review from kienstra April 25, 2018 19:53
@mehigh mehigh changed the title [WIP] 35 - Home styling responsiveness 35 - Home styling responsiveness Apr 25, 2018
@kienstra
Copy link
Contributor

Thanks, Icons Look Good

Hi @mehigh,
Thanks for your improvements to the icon alignment. Like you mentioned above, I also see that it's fixed:

horizontal-alignment

@kienstra kienstra merged commit 3d68715 into develop Apr 26, 2018
@kienstra kienstra deleted the feature/35-home-styling branch April 26, 2018 01:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants