Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Generate styling of homepage based on mockups + AMP Start #35

Open
postphotos opened this issue Apr 10, 2018 · 5 comments
Open

Generate styling of homepage based on mockups + AMP Start #35

postphotos opened this issue Apr 10, 2018 · 5 comments

Comments

@postphotos
Copy link

postphotos commented Apr 10, 2018

As a user, I expect AMP-valid CSS styling to render on top of the homepage's generated HTML markup.

Related #12.

Mockups are available here:

@postphotos postphotos changed the title Generate styling of homepage based on templates Generate styling of homepage based on mockups + AMP Start Apr 10, 2018
@postphotos
Copy link
Author

@mehigh, can you give us a status update on this so we can update the sprint board? Thanks! :)

@mehigh
Copy link
Member

mehigh commented Apr 21, 2018

I've just issued the PR for this and assigned it to Miina for code review:
#62

@kienstra
Copy link
Contributor

Request For Testing

Hi Claudio,
Could you please test the homepage, comparing it to the design?

@csossi
Copy link

csossi commented May 10, 2018

Thought it best to just point out all differences - am sure some are likely "ok as is"

Site: "Search for adventures" - Design: "Where would you like to go?" (2 locations)
Site: "Start date" - Design: "Departure"
Site: End date - Design: "Return"
Site: "From The Blog" - Design: "From the blog" (plus, "blog" box is much larger in Design than on Site)
Site: "Top Adventures" - Design: "Top Adventures Near You"

@kienstra
Copy link
Contributor

Request To Verify

Hi @csossi,
Thanks for bringing up these points.

@postphotos, could you please verify that we're alright with the first 3 points that @csossi raised above?

The last 2 points are (mainly) corrected with changes in the editor:

Site: "From The Blog" - Design: "From the blog" (plus, "blog" box is much larger in Design than on Site)
Site: "Top Adventures" - Design: "Top Adventures Near You"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants