This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
[WIP] Implement PSTT theme #38
Closed
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
832457c
merge CPT and Taxonomies
DavidCramer 4618a9a
update ignores
DavidCramer 183d75c
update ignores
DavidCramer 162af58
update ignores
DavidCramer 5fb53cb
bring in PSTT them and arrange taxonomies and CPT into ./dev
DavidCramer c4504d9
update ignores
DavidCramer 57c779d
update ignores
DavidCramer f0d36b6
install tasks and docs
DavidCramer 617ce4d
add dev-lib
DavidCramer d80ec0c
remove build files
DavidCramer 30b4bf5
change package and domain in dev and remove replace task from gulpfile
DavidCramer 3828eef
fix package, composer files, and PHPCS domain
DavidCramer de37094
travis change
DavidCramer 6c95a5e
fix PHPCS
DavidCramer 348782f
ignores
DavidCramer 9427ff1
add built theme files
DavidCramer 56ab41a
revert package.json
DavidCramer 2a93be9
revert composer.json
DavidCramer 7e83876
bring in develop and refactor around PSTT structures
DavidCramer 55f0beb
Move include below others to ensure last inclusion
DavidCramer 0346657
clean up input vars and sanitisation
DavidCramer 95cf160
retain isset over empty to allow clearing values.
DavidCramer e85ff4d
remove add_empty param.
DavidCramer 3a2d223
resolve merge conflicts
DavidCramer 1986e6e
merge develop
DavidCramer b68f4f2
merge develop and retructure files
DavidCramer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
<?php | ||
/** | ||
* The template for displaying 404 pages (not found) | ||
* | ||
* @link https://codex.wordpress.org/Creating_an_Error_404_Page | ||
* | ||
* @package WPAMPTheme | ||
*/ | ||
|
||
get_header(); ?> | ||
|
||
<main id="primary" class="site-main"> | ||
|
||
<section class="error-404 not-found"> | ||
<header class="page-header"> | ||
<h1 class="page-title"><?php esc_html_e( 'Oops! That page can’t be found.', 'travel' ); ?></h1> | ||
</header><!-- .page-header --> | ||
|
||
<div class="page-content"> | ||
<p><?php esc_html_e( 'It looks like nothing was found at this location. Maybe try one of the links below or a search?', 'travel' ); ?></p> | ||
|
||
<?php | ||
get_search_form(); | ||
|
||
the_widget( 'WP_Widget_Recent_Posts' ); | ||
?> | ||
|
||
<div class="widget widget_categories"> | ||
<h2 class="widget-title"><?php esc_html_e( 'Most Used Categories', 'travel' ); ?></h2> | ||
<ul> | ||
<?php | ||
wp_list_categories( | ||
array( | ||
'orderby' => 'count', | ||
'order' => 'DESC', | ||
'show_count' => 1, | ||
'title_li' => '', | ||
'number' => 10, | ||
) | ||
); | ||
?> | ||
</ul> | ||
</div><!-- .widget --> | ||
|
||
<?php | ||
|
||
/* translators: %1$s: smiley */ | ||
$archive_content = '<p>' . sprintf( esc_html__( 'Try looking in the monthly archives. %1$s', 'travel' ), convert_smilies( ':)' ) ) . '</p>'; | ||
the_widget( 'WP_Widget_Archives', 'dropdown=1', "after_title=</h2>$archive_content" ); | ||
|
||
the_widget( 'WP_Widget_Tag_Cloud' ); | ||
?> | ||
|
||
</div><!-- .page-content --> | ||
</section><!-- .error-404 --> | ||
|
||
</main><!-- #primary --> | ||
|
||
<?php | ||
get_footer(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,21 @@ A WordPress theme showcasing canonical AMP functionality. | |
|
||
Custom theme based on the [AMP Start Travel Theme](https://ampstart-iframes.firebaseapp.com/templates/travel/travel.amp), developed by XWP. | ||
|
||
## Developing | ||
Built on [PSTT theme](https://github.com/mor10/pstt). | ||
|
||
1. In command line, run `npm install` to install necessary node packages and dependencies. | ||
2. In command line, run `composer install` to install necessary PHP packages and dependencies. | ||
3. In command line, run `npm run build` to generate the theme. | ||
|
||
|
||
Travel uses a [Gulp](https://gulpjs.com/) build process to generate and optimize the code for the theme. All development is done in the `/dev` folder and Gulp preprocesses, transpiles, and compiles the files into the root folder. The root folder files become the active theme. WordPress ignores anything in the `/dev` folder. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for adding this "Developing" section. Does this line apply to this theme? It doesn't look like there's a |
||
|
||
JavaScript files are automatically linted using [ESLint](https://eslint.org/) in accordance with [WordPress Codeing Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/). | ||
|
||
PHP and CSS files are automatically linted using [PHP CodeSniffer](https://github.com/squizlabs/PHP_CodeSniffer) in accordance with [WordPress Codeing Standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/). To take full advantage of this setup, configure your code editor / IDE to automatically test for the WordPress Coding Standards. More details can be found at the [WordPres Coding Standards Wiki](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki). | ||
|
||
|
||
## Installation ## | ||
|
||
1. In your admin panel, go to Appearance > Themes and click the Add New button. | ||
|
@@ -24,4 +39,4 @@ Custom theme based on the [AMP Start Travel Theme](https://ampstart-iframes.fire | |
## Credits ## | ||
|
||
* Based on the [AMP Start Travel Theme](https://ampstart-iframes.firebaseapp.com/templates/travel/travel.amp) | ||
|
||
* Built with [PSTT theme](https://github.com/mor10/pstt) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe this should reflect the new name:
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
/*-------------------------------------------------------------- | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file probably won't be needed. |
||
# Comments | ||
--------------------------------------------------------------*/ | ||
.comment-content a { | ||
word-wrap: break-word; | ||
} | ||
|
||
.bypostauthor { | ||
display: block; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? It seems like Travis checks are running well, and
wp-dev-lib
is added todevDependencies
in package.json.