[WIP] Implement PSTT theme #38
Conversation
|
@kienstra - could you take a look at this and see if it looks correct according the the task? |
There was a problem hiding this comment.
Thanks, Some Points Below
Hi @DavidCramer,
Thanks for this huge effort. Most of these comments aren't regarding your work, only whether certain elements of the "WP Rig" theme will go along with our theme well.
This is an open discussion, so feel free to reply where you think something is needed.
comments.php
Outdated
| @@ -0,0 +1,78 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Thanks for adding this, but we'll probably use the comments.php from PR #39. That has AMP-specific markup, like <amp-live-list>.
| @@ -0,0 +1,10 @@ | |||
| /*-------------------------------------------------------------- | |||
There was a problem hiding this comment.
This file probably won't be needed.
| @@ -0,0 +1,176 @@ | |||
| /*-------------------------------------------------------------- | |||
There was a problem hiding this comment.
This probably isn't needed for now, as I haven't seen widgets in the design.
footer.php
Outdated
| @@ -0,0 +1,41 @@ | |||
| <?php | |||
There was a problem hiding this comment.
We'll probably use the footer.php from #39, as it's very specific to the design.
header.php
Outdated
| @@ -0,0 +1,52 @@ | |||
| <?php | |||
There was a problem hiding this comment.
We'll probably use the header.php from #39, as it's also very specific to the designs.
| The minimum version set here should be in line with the minimum WP version | ||
| as set in the "Requires at least" tag in the readme.txt file. --> | ||
| <rule ref="WordPress.WP.DeprecatedFunctions"> |
| @@ -58,5 +83,42 @@ | |||
|
|
|||
| <exclude-pattern>*/node_modules/*</exclude-pattern> | |||
| <exclude-pattern>*/vendor/*</exclude-pattern> | |||
| <exclude-pattern>*/html/*</exclude-pattern> | |||
| --> | ||
|
|
||
|
|
||
| <config name="testVersion" value="5.2-99.0"/> |
There was a problem hiding this comment.
It looks like travis.yml checks for PHP 5.6, 7.0, 7.1, and 7.2. Should this be:
value="5.6-99.0"
| @@ -0,0 +1,19 @@ | |||
| <?php | |||
There was a problem hiding this comment.
It doesn't look like the design has a sidebar, so I don't think we need this file. Still, I'm not sure if there are plans for a sidebar later.
| @@ -13,5 +13,893 @@ Tags: custom-background, custom-logo, custom-menu, featured-images, threaded-com | |||
| This theme, like WordPress, is licensed under the GPL. | |||
| Use it to make something cool, have fun, and share what you've learned with others. | |||
|
|
|||
| This stylesheet is intentionally left blank. | |||
| CSS normalization based in part on normalize.css by | |||
Huge work in progress.
functions.phpfile into theincludes/functions.phpfile that’s now in develop.requirestatements from the PSTTfunctions.phpfile.includes/classes.AMP_Travel_Featuresto init themes extractable features.^ cc @kienstra
Fixes #3