This repository has been archived by the owner on Oct 10, 2018. It is now read-only.
Adds 39 and several other WordPress templates. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopepasah
changed the title
westonruter
reviewed
Jan 30, 2018
inc/template-functions.php
Outdated
| * @return string $title | ||
| */ | ||
| function ampconf_get_the_archive_title( $title ) { | ||
| $parts = explode( ':', $title ); |
There was a problem hiding this comment.
Some languages may translate “:” differently for the strings found in get_the_archive_title() so this won't always work.
westonruter
reviewed
Jan 30, 2018
| // If comments are open or we have at least one comment, load up the comment template. | ||
| if ( comments_open() || get_comments_number() ) : | ||
| comments_template(); | ||
| endif; |
There was a problem hiding this comment.
Since comments are never shown on pages, I'll add remove_post_type_support( 'page', 'comments' );
westonruter
reviewed
Jan 30, 2018
templates/entry/full.php
Outdated
| ?> | ||
| <article id="post-<?php the_ID(); ?>" <?php post_class( 'entry entry--featured' ); ?>> | ||
| <figure class="entry__thumbnail"> | ||
| <a href="<?php esc_url( the_permalink() ); ?>"> |
There was a problem hiding this comment.
Note: the_permalink() echoes, so the esc_url() here will run on null, which won't get printed anyway. I'll change this to just the_permalink(), as the return goes through esc_url() already.
westonruter
reviewed
Jan 30, 2018
templates/entry/full.php
Outdated
| <figure class="entry__thumbnail"> | ||
| <a href="<?php esc_url( the_permalink() ); ?>"> | ||
| <?php the_post_thumbnail( 'ampconf-375x225' ); ?> | ||
| <?php the_post_thumbnail( 'ampconf-1040x400' ); ?> |
There was a problem hiding this comment.
Also: * Fix usage of the_permalink(). * Add some more phpdoc. * Add translation for share label.
westonruter
approved these changes
Jan 30, 2018
westonruter
reviewed
Jan 30, 2018
templates/entry/full.php
Outdated
|
|
||
| ?> | ||
| <article id="post-<?php the_ID(); ?>" <?php post_class( 'entry entry--featured' ); ?>> | ||
| <figure class="entry__thumbnail"> |
There was a problem hiding this comment.
@kopepasah should all instances of <figure class="entry__thumbnail"> be wrapped with <?php if ( has_post_thumbnail() ) : ?>?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched off and dependent onBranchadd/34.add/34has been merged intodevelop.